Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/select_file_dialog_extension.h" 5 #include "chrome/browser/ui/views/select_file_dialog_extension.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 : SelectFileDialog(listener, policy), 170 : SelectFileDialog(listener, policy),
171 has_multiple_file_type_choices_(false), 171 has_multiple_file_type_choices_(false),
172 routing_id_(), 172 routing_id_(),
173 profile_(NULL), 173 profile_(NULL),
174 owner_window_(NULL), 174 owner_window_(NULL),
175 selection_type_(CANCEL), 175 selection_type_(CANCEL),
176 selection_index_(0), 176 selection_index_(0),
177 params_(NULL) { 177 params_(NULL) {
178 } 178 }
179 179
180 void SelectFileDialogExtension::CloseImpl() {
181 NOTIMPLEMENTED();
182 }
183
180 SelectFileDialogExtension::~SelectFileDialogExtension() { 184 SelectFileDialogExtension::~SelectFileDialogExtension() {
181 if (extension_dialog_.get()) 185 if (extension_dialog_.get())
182 extension_dialog_->ObserverDestroyed(); 186 extension_dialog_->ObserverDestroyed();
183 } 187 }
184 188
185 bool SelectFileDialogExtension::IsRunning( 189 bool SelectFileDialogExtension::IsRunning(
186 gfx::NativeWindow owner_window) const { 190 gfx::NativeWindow owner_window) const {
187 return owner_window_ == owner_window; 191 return owner_window_ == owner_window;
188 } 192 }
189 193
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 } 425 }
422 426
423 // Connect our listener to FileDialogFunction's per-tab callbacks. 427 // Connect our listener to FileDialogFunction's per-tab callbacks.
424 AddPending(routing_id); 428 AddPending(routing_id);
425 429
426 extension_dialog_ = dialog; 430 extension_dialog_ = dialog;
427 params_ = params; 431 params_ = params;
428 routing_id_ = routing_id; 432 routing_id_ = routing_id;
429 owner_window_ = owner_window; 433 owner_window_ = owner_window;
430 } 434 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698