Add BrowserSelectFileDialogTest.OpenCloseFileDialog

chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <gdk/gdkx.h>
 #include <gtk/gtk.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
 
 #include <map>
 #include <set>
 #include <vector>
 
 // Xlib defines RootWindow
 #undef RootWindow
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_restrictions.h"
 #include "chrome/browser/ui/libgtk2ui/gtk2_signal.h"
 #include "chrome/browser/ui/libgtk2ui/gtk2_util.h"
 #include "chrome/browser/ui/libgtk2ui/select_file_dialog_impl.h"
 #include "ui/aura/window_observer.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/shell_dialogs/select_file_dialog.h"
 #include "ui/strings/grit/ui_strings.h"
+#include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 #include "ui/views/widget/desktop_aura/x11_desktop_handler.h"
 
 namespace {
 
 // Makes sure that .jpg also shows .JPG.
 gboolean FileFilterCaseInsensitive(const GtkFileFilterInfo* file_info,
                                    std::string* file_extension) {
   return base::EndsWith(file_info->filename, *file_extension,
                         base::CompareCase::INSENSITIVE_ASCII);
 }
 
 // Deletes |data| when gtk_file_filter_add_custom() is done with it.
 void OnFileFilterDataDestroyed(std::string* file_extension) {
   delete file_extension;
 }
 
 }  // namespace
 
 namespace libgtk2ui {
 
 // Implementation of SelectFileDialog that shows a Gtk common dialog for
 // choosing a file or folder. This acts as a modal dialog.
 class SelectFileDialogImplGTK : public SelectFileDialogImpl,
                                 public aura::WindowObserver {
  public:
   explicit SelectFileDialogImplGTK(Listener* listener,
                                    ui::SelectFilePolicy* policy);
 
+  // Close the file dialog.
+  void Close() override;
+
  protected:
   ~SelectFileDialogImplGTK() override;
 
   // BaseShellDialog implementation:
   bool IsRunning(gfx::NativeWindow parent_window) const override;
 
   // SelectFileDialog implementation.
   // |params| is user data we pass back via the Listener interface.
   void SelectFileImpl(Type type,
                       const base::string16& title,
@@ skipping 212 matching lines @@
   gtk_window_set_modal(GTK_WINDOW(dialog), TRUE);
 
   gtk_widget_show_all(dialog);
 
   // We need to call gtk_window_present after making the widgets visible to make
   // sure window gets correctly raised and gets focus.
   int time = views::X11DesktopHandler::get()->wm_user_time_ms();
   gtk_window_present_with_time(GTK_WINDOW(dialog), time);
 }
 
+void SelectFileDialogImplGTK::Close() {
+  // Close the file-picker.
+
+  // Get the focused dialog.
+  XID focused_window = 0;
+  int revert = 0;
+  XGetInputFocus(gfx::GetXDisplay(), &focused_window, &revert);
+
+  // Check if the focused window is the file-picker dialog.
+  for (auto it = dialogs_.begin(); it != dialogs_.end(); ++it) {
+    if (focused_window == GDK_WINDOW_XID(gtk_widget_get_window(*it))) {
+      gtk_widget_destroy(*it);
+      return;
+    }
+  }

[sadrul, 2015/11/02 01:31:38]

This seems unnecessarily complex (e.g. there's no reason the file-dialog has to
be focused when Close() is called). Why can't this just close all of dialogs_?
(I am not even convinced we still need to keep a set of dialogs_ here; I think
we can do away with tracking just one GtkWidget* for the dialog).

+
+  NOTREACHED() << "Cannot find the focused dialog";
+}
+
 void SelectFileDialogImplGTK::AddFilters(GtkFileChooser* chooser) {
   for (size_t i = 0; i < file_types_.extensions.size(); ++i) {
     GtkFileFilter* filter = NULL;
     std::set<std::string> fallback_labels;
 
     for (size_t j = 0; j < file_types_.extensions[i].size(); ++j) {
       const std::string& current_extension = file_types_.extensions[i][j];
       if (!current_extension.empty()) {
         if (!filter)
           filter = gtk_file_filter_new();
@@ skipping 352 matching lines @@
   g_free(filename);
   if (pixbuf) {
     gtk_image_set_from_pixbuf(GTK_IMAGE(preview_), pixbuf);
     g_object_unref(pixbuf);
   }
   gtk_file_chooser_set_preview_widget_active(GTK_FILE_CHOOSER(chooser),
                                              pixbuf ? TRUE : FALSE);
 }
 
 }  // namespace libgtk2ui