Allow using issue URL for git cl patch.

Allow using issue URL for git cl patch.

This CL allows passing the Rietveld URL to git cl patch along with the
CL number or patch URL.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296889

[dsinclair, 2015-09-23 19:02:01]

dsinclair@chromium.org changed reviewers:
+ scottmg@chromium.org

[dsinclair, 2015-09-23 19:02:02]

PTAL.

[scottmg, 2015-09-23 19:17:03]

scottmg@chromium.org changed reviewers:
+ dpranke@chromium.org

[scottmg, 2015-09-23 19:17:03]

+dirk because I'm not owners here.

https://codereview.chromium.org/1363043002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1363043002/diff/1/git_cl.py#newcode2875
git_cl.py:2875: def ParseIssueNum(arg):
nit; two blank lines between top level functions in .py, and add a """ comment.

https://codereview.chromium.org/1363043002/diff/1/git_cl.py#newcode2876
git_cl.py:2876: if re.match(r'\d+', arg):
maybe

  or args.endswith('.diff')

would be a safer way to make sure the patch case is still handled.

[dsinclair, 2015-09-23 19:22:28]

https://codereview.chromium.org/1363043002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1363043002/diff/1/git_cl.py#newcode2875
git_cl.py:2875: def ParseIssueNum(arg):
On 2015/09/23 19:17:03, scottmg wrote:
> nit; two blank lines between top level functions in .py, and add a """
comment.


Done.

Didn't see comments on the other ones, didn't realize the comments went inside
the method in python, heh.

https://codereview.chromium.org/1363043002/diff/1/git_cl.py#newcode2876
git_cl.py:2876: if re.match(r'\d+', arg):
On 2015/09/23 19:17:03, scottmg wrote:
> maybe
> 
>   or args.endswith('.diff')
> 
> would be a safer way to make sure the patch case is still handled.


It's not as easy to share in that case as the git cl checkout doesn't accept
.patch URLs. So, is it better not to share, or do it as I've done it? (Or am I
missing a third option?)

[scottmg, 2015-09-23 19:35:45]

https://codereview.chromium.org/1363043002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1363043002/diff/1/git_cl.py#newcode2876
git_cl.py:2876: if re.match(r'\d+', arg):
On 2015/09/23 19:22:28, dsinclair wrote:
> On 2015/09/23 19:17:03, scottmg wrote:
> > maybe
> > 
> >   or args.endswith('.diff')
> > 
> > would be a safer way to make sure the patch case is still handled.
> 
> 
> It's not as easy to share in that case as the git cl checkout doesn't accept
> .patch URLs. So, is it better not to share, or do it as I've done it? (Or am I
> missing a third option?)

Oh, right. OK, lgtm then.

[scottmg, 2015-09-25 20:57:54]

Dirk, could you take a look? (Having just tried to `git cl patch url` myself. :)

[Dirk Pranke, 2015-09-25 21:18:36]

oh, sorry, I missed that you needed an OWNERS approval.

lgtm.

[scottmg, 2015-09-25 21:20:04]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-09-25 21:20:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363043002/20001

[commit-bot: I haz the power, 2015-09-25 21:22:41]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296889