Implement ui for re-parenting an item from an app list folder to another position or folder in the …

ui/app_list/views/app_list_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_item_view.h"
 
 #include <algorithm>
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/app_list/app_list_constants.h"
@@ skipping 78 matching lines @@
   ItemIsInstallingChanged();
   item_->AddObserver(this);
 
   set_context_menu_controller(this);
   set_request_focus_on_press(false);
 
   SetAnimationDuration(0);
 }
 
 AppListItemView::~AppListItemView() {
-  item_->RemoveObserver(this);
+  if (item_)

[xiyuan, 2014/02/06 22:45:12]

When will this happen?

[jennyz, 2014/02/07 00:03:10]

You're right, I don't need to do so as long as making sure the view is always
removed before the item_. Removed this line.

+    item_->RemoveObserver(this);
 }
 
 void AppListItemView::SetIconSize(const gfx::Size& size) {
   if (icon_size_ == size)
     return;
 
   icon_size_ = size;
   UpdateIcon();
 }
 
@@ skipping 149 matching lines @@
 }
 
 void AppListItemView::Layout() {
   gfx::Rect rect(GetContentsBounds());
 
   const int left_right_padding =
       title_->font_list().GetExpectedTextWidth(kLeftRightPaddingChars);
   rect.Inset(left_right_padding, kTopPadding, left_right_padding, 0);
   const int y = rect.y();
 
-  gfx::Rect icon_bounds(rect.x(), y, rect.width(), icon_size_.height());
-  icon_bounds.Inset(gfx::ShadowValue::GetMargin(icon_shadows_));
-  icon_->SetBoundsRect(icon_bounds);
+  icon_->SetBoundsRect(GetIconBoundsForTargetViewBounds(GetContentsBounds()));
   const gfx::Size title_size = title_->GetPreferredSize();
   gfx::Rect title_bounds(rect.x() + (rect.width() - title_size.width()) / 2,
                          y + icon_size_.height() + kIconTitleSpacing,
                          title_size.width(),
                          title_size.height());
   title_bounds.Intersect(rect);
   title_->SetBoundsRect(title_bounds);
 
   gfx::Rect progress_bar_bounds(progress_bar_->GetPreferredSize());
   progress_bar_bounds.set_x(GetContentsBounds().x() +
@@ skipping 177 matching lines @@
 }
 
 void AppListItemView::OnSyncDragEnd() {
   SetUIState(UI_STATE_NORMAL);
 }
 
 const gfx::Rect& AppListItemView::GetIconBounds() const {
   return icon_->bounds();
 }
 
+void AppListItemView::SetDragUIState() {

[xiyuan, 2014/02/06 22:45:12]

nit: Move the block under GetIconBounds to be consistent with header.

[jennyz, 2014/02/07 00:03:10]

Isn't this just under GetIconsBound?

[xiyuan, 2014/02/07 00:32:19]

Oops, I am blind. :p

+  SetUIState(UI_STATE_DRAGGING);
+}
+
+gfx::Rect AppListItemView::GetIconBoundsForTargetViewBounds(
+    const gfx::Rect& target_bounds) {
+  gfx::Rect rect(target_bounds);
+
+  const int left_right_padding =
+      title_->font_list().GetExpectedTextWidth(kLeftRightPaddingChars);
+  rect.Inset(left_right_padding, kTopPadding, left_right_padding, 0);
+
+  gfx::Rect icon_bounds(rect.x(), rect.y(), rect.width(), icon_size_.height());
+  icon_bounds.Inset(gfx::ShadowValue::GetMargin(icon_shadows_));
+  return icon_bounds;
+}
+
 }  // namespace app_list