Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 136303004: Fix Win32 buildbreak (caused by overriden methods that have disappeared (Closed)

Created:
6 years, 11 months ago by Jarin
Modified:
6 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix Win32 buildbreak (caused by overriden methods that have disappeared while having the patch out for code review). R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 11 months ago (2014-01-15 17:41:28 UTC) #1
danno
lgtm. killing dead code is always good :-)
6 years, 11 months ago (2014-01-15 17:44:04 UTC) #2
Jarin
6 years, 11 months ago (2014-01-15 17:51:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698