Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1363023005: Implement FullScreen using top layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
index cffe90e1a6a699f5bde5aa09d48f237edde15443..83562d9e6ab7fa8ec6e3835b2d74f6ae543441ae 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
@@ -34,6 +34,8 @@
#include "core/dom/ContainerNode.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
+#include "core/dom/Fullscreen.h"
+#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/Settings.h"
#include "core/frame/UseCounter.h"
@@ -44,6 +46,7 @@
#include "core/html/HTMLTextAreaElement.h"
#include "core/layout/LayoutReplaced.h"
#include "core/layout/LayoutTheme.h"
+#include "core/page/Page.h"
#include "core/style/ComputedStyle.h"
#include "core/style/ComputedStyleConstants.h"
#include "core/svg/SVGSVGElement.h"
@@ -177,6 +180,19 @@ void StyleAdjuster::adjustComputedStyle(ComputedStyle& style, const ComputedStyl
adjustStyleForFirstLetter(style);
adjustStyleForDisplay(style, parentStyle, e ? &e->document() : 0);
+
+ if (e) {
+ if (Fullscreen::isActiveFullScreenElement(*e)) {
esprehn 2015/09/24 20:17:01 don't double nest, so this should be: if (e && Fu
dsinclair 2015/09/28 17:14:58 Done.
+ // We need to size the fullscreen element to the inner viewport and not to the
+ // outer viewport (what percentage would do). Unfortunately CSS can't handle
+ // that as we don't expose the inner viewport information.
+ //
+ // TODO(dsinclair): We should find a way to get this standardized. crbug.com/534924
+ IntSize viewportSize = e->document().page()->frameHost().visualViewport().size();
+ style.setWidth(Length(viewportSize.width(), Fixed));
+ style.setHeight(Length(viewportSize.height(), Fixed));
esprehn 2015/09/24 20:17:01 this seems bad, what if I resize my window? I don'
dsinclair 2015/09/28 17:14:58 So, override styleDidChange on LayoutView, get the
+ }
+ }
} else {
adjustStyleForFirstLetter(style);
}

Powered by Google App Engine
This is Rietveld 408576698