Implement FullScreen using top layer.

third_party/WebKit/Source/web/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
                 fullscreen->didExitFullScreenForElement(0);
             }
         }
     }
 
     m_fullScreenFrame.clear();
 }
 
 void FullscreenController::enterFullScreenForElement(Element* element)
 {
+    element->document().addToTopLayer(element);

[dsinclair, 2015/09/28 19:22:04]

This fixes up the WebView unit test crash by making sure the element we're
requesting fullscreen for is in the top layer. 

[esprehn, 2015/09/28 20:33:47]

It seems really weird that we need this in two places, why do we need it in both
pushFullscreenElementStack and here?

[philipj_slow, 2015/09/29 08:05:23]

I'm not sure if it's the case here, but there's a mode of operation where the
embedder just goes fullscreen and then notifies us, instead of asking us to
request fullscreen. It sure would be nice if there were just a single code path
for entering fullscreen, but I suspect that would make this CL a lot bigger. A
bug and TODO would be nice, though, if that is the root problem.

[dsinclair, 2015/10/01 14:50:14]

Added comment and filed bug.

+
     // We are already transitioning to fullscreen for a different element.
     if (m_provisionalFullScreenElement) {
         m_provisionalFullScreenElement = element;
         return;
     }
 
     // We are already in fullscreen mode.
     if (m_fullScreenFrame) {
         m_provisionalFullScreenElement = element;
         didEnterFullScreen();
         return;
     }
 
     // We need to transition to fullscreen mode.
     WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(element->document().frame());
     if (frame && frame->client()) {
         frame->client()->enterFullscreen();
         m_provisionalFullScreenElement = element;
     }
 }
 
 void FullscreenController::exitFullScreenForElement(Element* element)
 {
     ASSERT(element);
 
+    element->document().removeFromTopLayer(element);
+
     // The client is exiting full screen, so don't send a notification.
     if (m_isCancelingFullScreen)
         return;
 
     WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(element->document().frame());
     if (frame && frame->client())
         frame->client()->exitFullscreen();
 }
 
 void FullscreenController::updateSize()
 {
     if (!isFullscreen())
         return;
 
     updatePageScaleConstraints(false);
 
-    LayoutFullScreen* layoutObject = Fullscreen::from(*m_fullScreenFrame->document()).fullScreenLayoutObject();
-    if (layoutObject)
-        layoutObject->updateStyle();
+    Document* document = m_fullScreenFrame->document();
+    Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
+    if (fullscreenElement)
+        Fullscreen::from(fullscreenElement->document()).updatedSize(fullscreenElement);
 }
 
 void FullscreenController::updatePageScaleConstraints(bool removeConstraints)
 {
     PageScaleConstraints fullscreenConstraints;
     if (!removeConstraints) {
         fullscreenConstraints = PageScaleConstraints(1.0, 1.0, 1.0);
         fullscreenConstraints.layoutSize = IntSize(m_webViewImpl->size());
     }
     m_webViewImpl->pageScaleConstraintsSet().setFullscreenConstraints(fullscreenConstraints);
     m_webViewImpl->pageScaleConstraintsSet().computeFinalConstraints();
     m_webViewImpl->updateMainFrameLayoutSize();
 }
 
 DEFINE_TRACE(FullscreenController)
 {
     visitor->trace(m_provisionalFullScreenElement);
     visitor->trace(m_fullScreenFrame);
 }
 
 } // namespace blink