third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html - Issue 1363023005: Implement FullScreen using top layer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html

Issue 1363023005: Implement FullScreen using top layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html ('k') | third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html » ('j') | third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>
	esprehn 2015/09/24 20:17:01 leave out html, body leave out html, body dsinclair 2015/09/28 17:14:57 Done. Show quoted text On 2015/09/24 20:17:01, esprehn wrote: > leave out html, body Done.
	4 <style>

	5 div {

	6 top: 100px;

	7 bottom: 100px;

	8 left: 100px;

	9 right: 100px;

	10 height: auto;

	11 width: auto;

	12 }

	13 ::backdrop {

	14 background: green;

	15 }

	16 </style>

	17 </head>

	18 <body>

	19 <div>Test that fullscreen elements are in the top layer. The test passes if you see a green backdrop behind this box when fullscreen.</div>

	20 <button>Go fullscreen</button>

	21 <script>

	22 div = document.querySelector('div');
	esprehn 2015/09/24 20:17:01 Lets use an id instead so the test is clear (and l Lets use an id instead so the test is clear (and less brittle) dsinclair 2015/09/28 17:14:57 Done. Show quoted text On 2015/09/24 20:17:01, esprehn wrote: > Lets use an id instead so the test is clear (and less brittle) Done.
	23 document.querySelector('button').addEventListener('click', function() {

	24 div.webkitRequestFullscreen();

	25 });

	26 if (window.testRunner) {

	27 testRunner.waitUntilDone();

	28 document.addEventListener('webkitfullscreenchange', function() {

	29 setTimeout(function() {
	esprehn 2015/09/24 20:17:01 requestAnimationFrame? I'm not sure what you're wa requestAnimationFrame? I'm not sure what you're waiting for but setTimeout(0) is almost always wrong in a test dsinclair 2015/09/28 17:14:57 Done. Show quoted text On 2015/09/24 20:17:01, esprehn wrote: > requestAnimationFrame? I'm not sure what you're waiting for but setTimeout(0) is > almost always wrong in a test Done.
	30 testRunner.notifyDone();

	31 }, 0);

	32 });

	33 document.addEventListener('keydown', function() { div.webkitRequestFullscree n(); });
	esprehn 2015/09/24 20:17:01 on a new line on a new line dsinclair 2015/09/28 17:14:57 Done. Show quoted text On 2015/09/24 20:17:01, esprehn wrote: > on a new line Done.
	34 eventSender.keyDown('a');
	esprehn 2015/09/24 20:17:01 simulate a click instead, having both the keydown simulate a click instead, having both the keydown and the button is confusing dsinclair 2015/09/28 17:14:57 Done. Show quoted text On 2015/09/24 20:17:01, esprehn wrote: > simulate a click instead, having both the keydown and the button is confusing Done.
	35 }

	36 </script>

	37 </body>

	38 </html>

OLD	NEW