Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1362983005: Mac: Restore the show animation and subpixel AA for extension permissions prompts (Closed)

Created:
5 years, 3 months ago by tapted
Modified:
5 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Restore the show animation and subpixel AA for extension permissions prompts This regressed with the switchover to the 10.10 SDK. Extension prompts that had permissions text stopped animating when shown, and the permissions text lost its subpixel antialiasing. It's likely related to the "Responsive Scrolling" changes that came in with 10.9 and were disabled when linking to the 10.6 SDK. Giving the NSScrollView containing the permissions text a layer restores the show animation. Giving the NSOutlineView inside the NSScrollView an opaque background restores the subpixel AA. BUG=521901, 532791 TEST=At https://chrome.google.com/webstore/detail/nmljjlfbnbekmadhbpfpkcminoejelga click 'Add to Chrome'. The permissions prompt should animate in, and all the fonts should look smooth on a non-retina screen (particularly the blue 'Show Details' link). Committed: https://crrev.com/2866fa64ce3757530621d31558e2c17cd4de69e7 Cr-Commit-Position: refs/heads/master@{#350706}

Patch Set 1 #

Patch Set 2 : Fix animation as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Robert, please take a look
5 years, 3 months ago (2015-09-24 04:10:43 UTC) #2
Robert Sesek
LGTM
5 years, 3 months ago (2015-09-24 18:25:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362983005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362983005/20001
5 years, 3 months ago (2015-09-24 23:36:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-24 23:46:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 23:47:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2866fa64ce3757530621d31558e2c17cd4de69e7
Cr-Commit-Position: refs/heads/master@{#350706}

Powered by Google App Engine
This is Rietveld 408576698