Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1362983004: Mandoline: fix the crash when a remote subframe tries to access session storage. (Closed)

Created:
5 years, 3 months ago by yzshen1
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: fix the crash when a remote subframe tries to access session storage. BUG=535005 TEST=None Committed: https://crrev.com/e6f40586296c669908c1a71b599a6ce47082b5f8 Cr-Commit-Position: refs/heads/master@{#350478}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M components/html_viewer/html_widget.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M components/html_viewer/html_widget.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years, 3 months ago (2015-09-23 23:47:04 UTC) #2
sky
LGTM https://codereview.chromium.org/1362983004/diff/1/components/html_viewer/html_widget.h File components/html_viewer/html_widget.h (right): https://codereview.chromium.org/1362983004/diff/1/components/html_viewer/html_widget.h#newcode49 components/html_viewer/html_widget.h:49: virtual bool HTMLWidgetRootRemote::allowsBrokenNullLayerTreeView() const; remove HTMLWidgetRootRemote::
5 years, 3 months ago (2015-09-23 23:56:24 UTC) #3
yzshen1
Thanks, Scott! https://codereview.chromium.org/1362983004/diff/1/components/html_viewer/html_widget.h File components/html_viewer/html_widget.h (right): https://codereview.chromium.org/1362983004/diff/1/components/html_viewer/html_widget.h#newcode49 components/html_viewer/html_widget.h:49: virtual bool HTMLWidgetRootRemote::allowsBrokenNullLayerTreeView() const; On 2015/09/23 23:56:24, ...
5 years, 3 months ago (2015-09-24 03:55:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362983004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362983004/20001
5 years, 3 months ago (2015-09-24 03:56:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-24 04:56:26 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 04:58:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6f40586296c669908c1a71b599a6ce47082b5f8
Cr-Commit-Position: refs/heads/master@{#350478}

Powered by Google App Engine
This is Rietveld 408576698