Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1362973003: Verify other multi-frame concerns in SaveCrossSitePage test. (Closed)

Created:
5 years, 2 months ago by Łukasz Anforowicz
Modified:
5 years, 2 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify other multi-frame concerns in SaveCrossSitePage test. After the changes the test: - Continues to test cross-site / multiple-renderer-processes case. - Starts to verify that frame links got correctly replaced with local paths (this uses a separate code path from replacing links of other, non-frame savable resources). - Starts to test that deduplication of savable resources happens across frames (deduplication got moved into the browser process in https://chromium.googlesource.com/chromium/src/+/6af746b740287560dbc9e85d22738000bc72b521). BUG=526786 Committed: https://crrev.com/4bfb141876bc334c47688ee74d710692eed3ec31 Cr-Commit-Position: refs/heads/master@{#351133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 4 chunks +21 lines, -5 lines 0 comments Download
A chrome/test/data/save_page/iframes.htm View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Łukasz Anforowicz
Randy, could you please take a look? (small, test-only CL)
5 years, 2 months ago (2015-09-23 20:07:29 UTC) #2
Łukasz Anforowicz
Asanka, could you please take a look? (I believe Randy is out of office for ...
5 years, 2 months ago (2015-09-25 18:14:00 UTC) #4
Randy Smith (Not in Mondays)
LGTM (sorry, you were quite right, I was OOO).
5 years, 2 months ago (2015-09-28 00:38:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362973003/1
5 years, 2 months ago (2015-09-28 16:04:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:52:02 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:53:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bfb141876bc334c47688ee74d710692eed3ec31
Cr-Commit-Position: refs/heads/master@{#351133}

Powered by Google App Engine
This is Rietveld 408576698