third_party/WebKit/Source/core/fileapi/Blob.h - Issue 1362963003: Blob/File constructors/slice method shouldn't throw on invalid types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/Blob.h

Issue 1362963003: Blob/File constructors/slice method shouldn't throw on invalid types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated win expectation Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/external/wpt/FileAPI/blob/Blob-constructor-expected.txt ('k') | third_party/WebKit/Source/core/fileapi/Blob.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/Blob.h

diff --git a/third_party/WebKit/Source/core/fileapi/Blob.h b/third_party/WebKit/Source/core/fileapi/Blob.h

index 99097137f73638f8e7f32ababb4f163a39574bb3..aa69ca27b39d3c7cc141180bbef140a61914f662 100644

--- a/third_party/WebKit/Source/core/fileapi/Blob.h

+++ b/third_party/WebKit/Source/core/fileapi/Blob.h

@@ -132,6 +132,11 @@ class CORE_EXPORT Blob : public GarbageCollectedFinalized<Blob>,

long long& start,

long long& end);

+ // Called by the Blob and File constructors when processing the 'type'

+ // option per the FileAPI standard. Returns "" if |type| contains any

+ // character outside U+0020...U+007E, or |type| ASCII-lowercased otherwise.

+ static String normalizeType(const String& type);

private:

Blob();