Scale large notification icons according to device settings.

Scale large notification icons according to device settings.

Previously we would directly pass developer-provided icons on to the
Android NotificationManager, but this has led to OOM errors on devices
with less memory when developers provide, supposedly, large icons.

Starting from this CL, we ensure that icons are at most the size at
which they will be presented to the user.

BUG=529980
Committed: https://crrev.com/c409a15aec57abe523fd57e4a3b8eb98cce5506e
Cr-Commit-Position: refs/heads/master@{#350514}

[Peter Beverloo, 2015-09-23 13:30:22]

peter@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-09-23 13:30:22]

+mvanouwerkerk, PTAL, this is the current #10 crash in M45.

[Michael van Ouwerkerk, 2015-09-23 13:52:49]

lgtm with nits

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
(right):

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:99:
* @return The instance of the NotificationUIManager, if any.
nit: if it can be null, consider adding @Nullable and document when it is null.

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:397:
*             the platforms, whereas a default icon will be generated for
invaild Bitmaps.
nit: s/invaild/invalid/

https://codereview.chromium.org/1362943002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/1362943002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:288:
Bitmap fromSmallIcon = manager.ensureNormalizedIcon(smallIcon, origin);
Do you want to assert that fromSmallIcon == smallIcon? It's an indication that
no needless work is done.

[Peter Beverloo, 2015-09-23 14:40:06]

Thanks Michael!

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
(right):

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:99:
* @return The instance of the NotificationUIManager, if any.
On 2015/09/23 13:52:49, Michael van Ouwerkerk wrote:
> nit: if it can be null, consider adding @Nullable and document when it is
null.

Done.

https://codereview.chromium.org/1362943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:397:
*             the platforms, whereas a default icon will be generated for
invaild Bitmaps.
On 2015/09/23 13:52:49, Michael van Ouwerkerk wrote:
> nit: s/invaild/invalid/

Done.

https://codereview.chromium.org/1362943002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/1362943002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:288:
Bitmap fromSmallIcon = manager.ensureNormalizedIcon(smallIcon, origin);
On 2015/09/23 13:52:49, Michael van Ouwerkerk wrote:
> Do you want to assert that fromSmallIcon == smallIcon? It's an indication that
> no needless work is done.

Done.

[Peter Beverloo, 2015-09-23 18:11:49]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-09-23 18:11:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1362943002/#ps20001
(title: "address review comments")

[commit-bot: I haz the power, 2015-09-23 18:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362943002/20001

[commit-bot: I haz the power, 2015-09-23 19:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:44:05]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Peter Beverloo, 2015-09-24 08:32:09]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-09-24 08:32:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1362943002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-09-24 08:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362943002/40001

[commit-bot: I haz the power, 2015-09-24 09:32:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-24 09:33:03]

Patchset 3 (id:??) landed as
https://crrev.com/c409a15aec57abe523fd57e4a3b8eb98cce5506e
Cr-Commit-Position: refs/heads/master@{#350514}

[Theresa, 2015-09-25 17:02:58]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1370733002/ by twellington@chromium.org.

The reason for reverting is:
NotificationUIManagerTest#testShowNotificationWithIcon failing on
instrumentation-nakasi-clankium and occam-svlete-clankium after this change:

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrum...

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/instrum...
.