Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362933003: Remove MediaStream label, ended attributes and stop() method (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MediaStream label, ended attributes and stop() method Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LcZGlM9OBqs Intent to Remove, which became an Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ Depends on CL: https://codereview.chromium.org/1344753002/ https://codereview.chromium.org/1349273003/ BUG=338500 Committed: https://crrev.com/ec7a7c5064c87ddf3dcba31a3bdf5981ad32e912 Cr-Commit-Position: refs/heads/master@{#350528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -101 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended.html View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamConstructor.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 4 chunks +2 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shiva.jm
pls have a look, these CL is merge from https://codereview.chromium.org/1312213006/. since after blink merge, we ...
5 years, 3 months ago (2015-09-24 09:00:33 UTC) #2
philipj_slow
lgtm
5 years, 3 months ago (2015-09-24 09:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362933003/1
5 years, 3 months ago (2015-09-24 09:11:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 10:55:58 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 10:57:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ec7a7c5064c87ddf3dcba31a3bdf5981ad32e912
Cr-Commit-Position: refs/heads/master@{#350528}

Powered by Google App Engine
This is Rietveld 408576698