Gallery: keep exif info if image is saved to a copy.

Gallery: keep exif info if image is saved to a copy.

BUG=526691
TEST=none

Committed: https://crrev.com/f7e1a053ab897fe8abb653349e8358c84c8f6393
Cr-Commit-Position: refs/heads/master@{#350773}

[yawano, 2015-09-24 05:19:50]

yawano@chromium.org changed reviewers:
+ hirono@chromium.org

[yawano, 2015-09-24 05:19:50]

PTAL. Thank you!

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/gallery_item.js (left):

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/gallery_item.js:316: [fileEntry],
The cause of this issue is this line. When an edit has been saved to a copy,
fileEntry here is a new entry while it should be the old entry.

[hirono, 2015-09-24 08:42:50]

lgtm

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/gallery_item.js:343: callback(false);
nit: It looks callback should be non-null.

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/gallery_item.js:385: directory.getFile(name, {create:
false, exclusive: false},
Could not we specify {create: true, exclusive: false} instead of calling getFile
twice?

[yawano, 2015-09-24 10:22:57]

Thank you for the review!

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/gallery_item.js:343: callback(false);
On 2015/09/24 08:42:50, hirono wrote:
> nit: It looks callback should be non-null.

Done.

https://codereview.chromium.org/1362873003/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/gallery_item.js:385: directory.getFile(name, {create:
false, exclusive: false},
Yes, we don't need to check existence of the entry here. Done. Thank you!

[yawano, 2015-09-24 10:23:00]

The CQ bit was checked by yawano@chromium.org

[yawano, 2015-09-24 10:23:01]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1362873003/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-09-24 10:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362873003/40001

[commit-bot: I haz the power, 2015-09-24 11:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 11:30:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yawano, 2015-09-25 04:54:13]

@hirono: Fixed failed test case. PTAL again. Thank you!

[hirono, 2015-09-25 05:02:15]

still lgtm

[yawano, 2015-09-25 05:02:35]

On 2015/09/25 05:02:15, hirono wrote:
> still lgtm

Thank you!

[yawano, 2015-09-25 05:02:38]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-09-25 05:02:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362873003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362873003/60001

[commit-bot: I haz the power, 2015-09-25 05:08:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-25 05:08:58]

Patchset 4 (id:??) landed as
https://crrev.com/f7e1a053ab897fe8abb653349e8358c84c8f6393
Cr-Commit-Position: refs/heads/master@{#350773}