Always use 'max' optimizations for Windows builds

Always use 'max' optimizations for Windows builds

libvpx previously had issues with optimize=max and size. These have been resolved by the move away from obj_int_extract and gn builds already specify 'max'.

https://code.google.com/p/webm/issues/detail?id=735
BUG=352476
R=sebmarchand@chromium.org,tomfinegan@chromium.org

Committed: https://crrev.com/9b3408a4b6a218a63e37836176b3b02f0e81354f
Cr-Commit-Position: refs/heads/master@{#350382}

[Johann, 2015-09-22 23:05:55]

johannkoenig@google.com changed reviewers:
+ sebmarchand@chromium.org

[Johann, 2015-09-22 23:06:56]

There doesn't appear to be a way to check for 'debug' builds in gyp:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/n-PSGVNZ16E

This boosts libvpx up to max optimizations all the time.

[sebmarchand (DO NOT USE), 2015-09-23 13:28:01]

sebmarchand@google.com changed reviewers:
+ sebmarchand@google.com

[sebmarchand (DO NOT USE), 2015-09-23 13:28:01]

lgtm, although I'm not sure what's happening on the win8 trybot

[Johann, 2015-09-23 17:43:52]

On 2015/09/23 13:28:01, sebmarchand (DO NOT USE) wrote:
> lgtm, although I'm not sure what's happening on the win8 trybot

I thought maybe it had something to do with chrome_build.gni, but that's
strictly for the 'official' tag. It looks like optimize_max is in
build/config/compiler/BUILD.gn, so I'm going to reupload with
build/config/compiler/compiler.gni included and see what happens? or maybe
rebase first and see if it passes, and then add compiler.gni

[Tom Finegan, 2015-09-23 17:57:36]

On 2015/09/23 17:43:52, Johann wrote:
> On 2015/09/23 13:28:01, sebmarchand (DO NOT USE) wrote:
> > lgtm, although I'm not sure what's happening on the win8 trybot
> 
> I thought maybe it had something to do with chrome_build.gni, but that's
> strictly for the 'official' tag. It looks like optimize_max is in
> build/config/compiler/BUILD.gn, so I'm going to reupload with
> build/config/compiler/compiler.gni included and see what happens? or maybe
> rebase first and see if it passes, and then add compiler.gni

lgtm

[Johann, 2015-09-23 18:27:27]

The CQ bit was checked by johannkoenig@google.com

[Johann, 2015-09-23 18:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sebmarchand@google.com, tomfinegan@chromium.org
Link to the patchset: https://codereview.chromium.org/1362783002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-09-23 18:28:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362783002/40001

[Johann, 2015-09-23 18:33:55]

The CQ bit was unchecked by johannkoenig@google.com

[commit-bot: I haz the power, 2015-09-23 18:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 18:36:51]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Johann, 2015-09-23 18:38:22]

Everyone else using optimization_max is removing default_optimization. It looks
like it switched a while back:

git grep -A2 -B1 compiler\:default_optimization
<...>
base/BUILD.gn-  if (!is_debug) {
base/BUILD.gn:    configs -= [ "//build/config/compiler:default_optimization" ]
base/BUILD.gn-    configs += [ "//build/config/compiler:optimize_max" ]
base/BUILD.gn-  }
<...>
cc/BUILD.gn-  if (!is_debug && (is_win || is_android)) {
cc/BUILD.gn:    configs -= [ "//build/config/compiler:default_optimization" ]
cc/BUILD.gn-    configs += [ "//build/config/compiler:optimize_max" ]
cc/BUILD.gn-  }
<...>

libvpx probably just missed the switch.

[Johann, 2015-09-23 18:38:31]

The CQ bit was checked by johannkoenig@google.com

[Johann, 2015-09-23 18:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sebmarchand@google.com, tomfinegan@chromium.org
Link to the patchset: https://codereview.chromium.org/1362783002/#ps60001
(title: "default_optimization")

[commit-bot: I haz the power, 2015-09-23 18:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362783002/60001

[commit-bot: I haz the power, 2015-09-23 19:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:37:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Johann, 2015-09-23 21:23:36]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2015-09-23 21:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362783002/60001

[commit-bot: I haz the power, 2015-09-23 23:08:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-23 23:09:28]

Patchset 4 (id:??) landed as
https://crrev.com/9b3408a4b6a218a63e37836176b3b02f0e81354f
Cr-Commit-Position: refs/heads/master@{#350382}