Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1362773002: [es6] Align Promise.resolve with the spec (Closed)

Created:
5 years, 3 months ago by stefan.penner
Modified:
5 years, 2 months ago
Reviewers:
domenic, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Align Promise.resolve with the spec * Promise.resolve is now works with subclasses * Spec removed [[PromiseConstructor]] now can simply use constructor * Promise.resolve ignores species R=littledan@chromium.org,domenic@chromium.org BUG=v8:4161, v8:4341 LOG=Y Committed: https://crrev.com/dcbab0f5fba01d3d48093865b8098aecb73ae5f9 Cr-Commit-Position: refs/heads/master@{#31116}

Patch Set 1 #

Patch Set 2 : Keep lines within 80char #

Patch Set 3 : fix typo during refactoring #

Patch Set 4 : remove corresponding entry from patch262.status (that scenario is now passing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M src/promise.js View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 2 3 2 chunks +27 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
stefan.penner
[es6] Align Promise.resolve with the spec * Promise.resolve is now works with subclasses * Spec ...
5 years, 3 months ago (2015-09-22 22:12:34 UTC) #1
domenic
lgtm from spec compliance perspective, and tests seem reasonably comprehensive too. (I am not a ...
5 years, 3 months ago (2015-09-22 22:18:25 UTC) #2
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-09-25 21:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362773002/40001
5 years, 2 months ago (2015-09-30 20:07:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10114)
5 years, 2 months ago (2015-09-30 20:25:37 UTC) #8
stefan.penner
On 2015/09/30 at 20:25:37, commit-bot wrote: > Try jobs failed on following builders: > v8_linux_rel ...
5 years, 2 months ago (2015-10-02 14:57:10 UTC) #9
stefan.penner
On 2015/10/02 at 14:57:10, stefan.penner wrote: > On 2015/09/30 at 20:25:37, commit-bot wrote: > > ...
5 years, 2 months ago (2015-10-05 15:43:52 UTC) #10
stefan.penner
On 2015/10/05 at 15:43:52, stefan.penner wrote: > On 2015/10/02 at 14:57:10, stefan.penner wrote: > > ...
5 years, 2 months ago (2015-10-05 21:07:52 UTC) #11
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-05 21:38:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362773002/60001
5 years, 2 months ago (2015-10-05 21:38:38 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-05 22:21:13 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:21:34 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dcbab0f5fba01d3d48093865b8098aecb73ae5f9
Cr-Commit-Position: refs/heads/master@{#31116}

Powered by Google App Engine
This is Rietveld 408576698