Issue 136273007: Fix gyp on OS X with use_goma=1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136273007: Fix gyp on OS X with use_goma=1. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix gyp on OS X with use_goma=1. Adds linux/BUILD.gn change from https://codereview.chromium.org/117863003 to mac/BUILD.gn. Ugly, but good enough to unbreak my (and other people's) build. BUG=335819 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245698

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	build/toolchain/mac/BUILD.gn	View		2 chunks	+22 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/136273007/diff/1/build/toolchain/mac/BUILD.gn File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/136273007/diff/1/build/toolchain/mac/BUILD.gn#newcode9 build/toolchain/mac/BUILD.gn:9: import("../goma.gni") I've been trying to do absolute paths ...

6 years, 11 months ago (2014-01-18 22:04:52 UTC) #2

Nico

6 years, 11 months ago (2014-01-18 22:06:03 UTC) #3

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/136273007/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/136273007/diff/1/build/toolchain/mac/BUILD.gn...
build/toolchain/mac/BUILD.gn:9: import("../goma.gni")
On 2014/01/18 22:04:52, brettw wrote:
> I've been trying to do absolute paths for imports like we do in C++
> ("//build/toolchain/goma.gni").

I'll try to remember :-) I cribbed this from toolchain/linux/BUILD.gn, which
also has a relative import at the moment.

Expand Messages | Collapse Messages