Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/build/scripts/make_runtime_features.py

Issue 1362703003: Remove obsolete deprecated status for REF generator script. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/audit_runtime_enabled_features.py ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_runtime_features.py
diff --git a/Source/build/scripts/make_runtime_features.py b/Source/build/scripts/make_runtime_features.py
index 20a119a56a2e333902e4944cc9e2ea18828da2f8..cea5b3d0ffc212c89eb2a67d3e4901ee55245e56 100755
--- a/Source/build/scripts/make_runtime_features.py
+++ b/Source/build/scripts/make_runtime_features.py
@@ -43,7 +43,7 @@ class RuntimeFeatureWriter(in_generator.Writer):
# FIXME: valid_values and defaults should probably roll into one object.
valid_values = {
- 'status': ['stable', 'experimental', 'test', 'deprecated'],
+ 'status': ['stable', 'experimental', 'test'],
}
defaults = {
'condition': None,
@@ -53,10 +53,6 @@ class RuntimeFeatureWriter(in_generator.Writer):
'status': None,
}
- _status_aliases = {
- 'deprecated': 'test',
- }
-
def __init__(self, in_file_path):
super(RuntimeFeatureWriter, self).__init__(in_file_path)
self._outputs = {(self.class_name + '.h'): self.generate_header,
@@ -67,7 +63,6 @@ class RuntimeFeatureWriter(in_generator.Writer):
# Make sure the resulting dictionaries have all the keys we expect.
for feature in self._features:
feature['first_lowered_name'] = lower_first(feature['name'])
- feature['status'] = self._status_aliases.get(feature['status'], feature['status'])
# Most features just check their isFooEnabled bool
# but some depend on or are implied by other bools.
enabled_condition = 'is%sEnabled' % feature['name']
@@ -82,7 +77,7 @@ class RuntimeFeatureWriter(in_generator.Writer):
def _feature_sets(self):
# Another way to think of the status levels is as "sets of features"
# which is how we're referring to them in this generator.
- return [status for status in self.valid_values['status'] if status not in self._status_aliases]
+ return list(self.valid_values['status'])
@template_expander.use_jinja(class_name + '.h.tmpl', filters=filters)
def generate_header(self):
« no previous file with comments | « Source/build/scripts/audit_runtime_enabled_features.py ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698