Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1362693004: When style changes, set the LayoutObject as a client for all StyleImage loads. (Closed)

Created:
5 years, 2 months ago by Nate Chapin
Modified:
5 years, 2 months ago
Reviewers:
esprehn
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When style changes, set the LayoutObject as a client for all StyleImage loads We have logic to dynamically change an image load's ResourceLoadPriority based on whether it is in the viewport. We would like to generalize this logic to support other types of resources and other factors for priority. To do that, we need to ensure every image that might be in the viewport is associated with a LayoutObject, so that it can pull its priority state, rather than having the LayoutObject push the state. We have not been consistent about ensuring that every LayoutObject registers itself as a client with every StyleImage in its ComputedStyle. This change ensures that we do so. BUG=536147 Committed: https://crrev.com/c5ce89c70400c6165fade1c9f40dae2543cbc89b Cr-Commit-Position: refs/heads/master@{#350946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nate Chapin
This is the post-merge continuation of https://codereview.chromium.org/1342503002/
5 years, 2 months ago (2015-09-23 19:34:44 UTC) #2
esprehn
lgtm, is there a bug associated with this? Can you expand the description for why ...
5 years, 2 months ago (2015-09-25 20:05:21 UTC) #3
Nate Chapin
On 2015/09/25 20:05:21, esprehn wrote: > lgtm, is there a bug associated with this? Can ...
5 years, 2 months ago (2015-09-25 20:14:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362693004/1
5 years, 2 months ago (2015-09-25 22:22:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 23:34:20 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 23:35:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5ce89c70400c6165fade1c9f40dae2543cbc89b
Cr-Commit-Position: refs/heads/master@{#350946}

Powered by Google App Engine
This is Rietveld 408576698