Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1362683002: PPC: [ic] Introduce BOOLEAN state for CompareIC. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [ic] Introduce BOOLEAN state for CompareIC. Port 10c5f2e85ef92b7ca002ef95e406d5dc4f0c410b Original commit message: Slow path for relational comparison of boolean primitive values now goes through the runtime, which made the slow path even slower than it already was. So in order to repair the regression, we just track boolean feedback for comparisons and use that to generate decent code in Crankshaft (not the best possible code, but good enough for Crankshaft; TurboFan will be able to do better on that). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:534200 LOG=n Committed: https://crrev.com/3028534498c236563f7e426f87f9a5298992eb7f Cr-Commit-Position: refs/heads/master@{#30871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-22 18:50:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362683002/1
5 years, 3 months ago (2015-09-22 18:50:58 UTC) #3
michael_dawson
On 2015/09/22 18:50:58, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-09-22 18:53:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 19:35:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362683002/1
5 years, 3 months ago (2015-09-22 19:40:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 19:42:08 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:42:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3028534498c236563f7e426f87f9a5298992eb7f
Cr-Commit-Position: refs/heads/master@{#30871}

Powered by Google App Engine
This is Rietveld 408576698