include/core/SkTSearch.h - Issue 1362613002: Fix possible integer overflow in SkTSearch's midpoint calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTSearch.h

Issue 1362613002: Fix possible integer overflow in SkTSearch's midpoint calculation (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Fix operator precedence Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkTSearch.h

diff --git a/include/core/SkTSearch.h b/include/core/SkTSearch.h

index a4e4994ef378b2b14a39c1da2daa601c35677f71..549bcfd7c844ef7e0e51f616b634fe8833f21dbd 100644

--- a/include/core/SkTSearch.h

+++ b/include/core/SkTSearch.h

@@ -49,7 +49,7 @@ int SkTSearch(const T base[], int count, const K& key, size_t elemSize, LESS& le

int hi = count - 1;

while (lo < hi) {

- int mid = (hi + lo) >> 1;

+ int mid = lo + ((hi - lo) >> 1);

const T* elem = (const T*)((const char*)base + mid * elemSize);

if (less(*elem, key))

« no previous file with comments | « no previous file | no next file » | no next file with comments »