Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1362613002: Fix possible integer overflow in SkTSearch's midpoint calculation (Closed)

Created:
5 years, 3 months ago by mdempsky
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix possible integer overflow in SkTSearch's midpoint calculation Probably unlikely to matter in practice, but SkTQSort calculates its midpoint correctly, so we might as well do it here too. For more background, see Joshua Bloch's "Nearly All Binary Searches and Mergesorts are Broken" post: http://googleresearch.blogspot.ru/2006/06/extra-extra-read-all-about-it-nearly.html This doesn't change any public API. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/07ed41fa405fe5f22c85f2fc9935397bbaa9c13b

Patch Set 1 #

Patch Set 2 : Fix operator precedence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkTSearch.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362613002/1
5 years, 3 months ago (2015-09-22 15:34:26 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-22 15:34:27 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1656) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
5 years, 3 months ago (2015-09-22 15:35:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362613002/20001
5 years, 3 months ago (2015-09-22 15:38:24 UTC) #7
mtklein
lgtm This doesn't change any public API, so feel free to add: " This doesn't ...
5 years, 3 months ago (2015-09-22 16:05:26 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 16:05:51 UTC) #11
mdempsky
On 2015/09/22 16:05:26, mtklein wrote: > lgtm > > This doesn't change any public API, ...
5 years, 3 months ago (2015-09-22 16:13:31 UTC) #12
mtklein
On 2015/09/22 16:13:31, mdempsky wrote: > On 2015/09/22 16:05:26, mtklein wrote: > > lgtm > ...
5 years, 3 months ago (2015-09-22 17:31:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362613002/20001
5 years, 3 months ago (2015-09-22 17:31:24 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 17:32:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/07ed41fa405fe5f22c85f2fc9935397bbaa9c13b

Powered by Google App Engine
This is Rietveld 408576698