content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java - Issue 1362603002: Straighten up keyboard hide and show logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

Issue 1362603002: Straighten up keyboard hide and show logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a TODO and fixed test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreInputConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

index 5ae6b380de9667805d1ffc3daea7bbaa736f6d62..f2178a00391894a082545be72544ced0dde16d64 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

@@ -56,10 +56,10 @@ public class ContentViewCoreFocusTest extends ContentShellTestBase {

// view loses its focus

final ContentViewCore contentViewCore = getContentViewCore();

final View view = contentViewCore.getContainerView();

- final TestInputMethodManagerWrapper immw = new TestInputMethodManagerWrapper(getActivity());

assertTrue(view.requestFocus());

- contentViewCore.setInputMethodManagerWrapperForTest(immw);

+ final TestInputMethodManagerWrapper immw = new TestInputMethodManagerWrapper(getActivity());

+ contentViewCore.getImeAdapterForTest().setInputMethodManagerWrapperForTest(immw);

immw.showSoftInput(view, 0, null);

assertFalse(immw.isHidden());