Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1362573002: X87: [builtins] Add support for NewTarget to Execution::New. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Add support for NewTarget to Execution::New. port 1dfac69f1fb5ad8e2db2d5be591c094def55d451 (r30857). original commit message: Introduce new builtins Construct and ConstructFunction (in line with the Call and CallFunction builtins that we already have) as proper bottleneck for Construct and [[Construct]] on JSFunctions. Use these builtins to support passing NewTarget from C++ to JavaScript land. Long-term we want the CallConstructStub to be used for gathering feedback on entry to construction chain (i.e. the initial new Foo), and use the Construct builtins to do the actual work inside the construction chain (i.e. calling into super and stuff). BUG= Committed: https://crrev.com/5ced12c154a88058ce5b83ccbaaefb0e8edd6ef2 Cr-Commit-Position: refs/heads/master@{#30899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -66 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/x87/builtins-x87.cc View 5 chunks +87 lines, -18 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +14 lines, -41 lines 0 comments Download
M src/x87/frames-x87.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-23 06:25:05 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 03:21:18 UTC) #4
Weiliang
lgtm lgtm
5 years, 3 months ago (2015-09-24 03:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362573002/1
5 years, 3 months ago (2015-09-24 03:21:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 03:52:00 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 03:52:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ced12c154a88058ce5b83ccbaaefb0e8edd6ef2
Cr-Commit-Position: refs/heads/master@{#30899}

Powered by Google App Engine
This is Rietveld 408576698