Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362333002: Clean up rewriter. (Closed)

Created:
5 years, 3 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up rewriter. The main changes are: - Fix treatment of loops, which was incorrect and sometimes resulted in the wrong completion value. - Get rid of unnecessary variables. This is in preparation of implementing ES6 completion semantics. R=rossberg BUG= Committed: https://crrev.com/b466dc14791844b7ae6d1e9ebd00a778965c206d Cr-Commit-Position: refs/heads/master@{#30981}

Patch Set 1 #

Patch Set 2 : Fix webkit tests and rewriting of throw. #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -45 lines) Patch
M src/rewriter.cc View 1 2 3 6 chunks +33 lines, -35 lines 0 comments Download
M test/webkit/eval-throw-return.js View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/eval-throw-return-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
neis
5 years, 2 months ago (2015-09-24 14:45:18 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-09-28 11:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362333002/1
5 years, 2 months ago (2015-09-28 11:37:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/10006)
5 years, 2 months ago (2015-09-28 11:45:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362333002/20001
5 years, 2 months ago (2015-09-28 12:38:02 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/4751)
5 years, 2 months ago (2015-09-28 12:45:56 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362333002/40001
5 years, 2 months ago (2015-09-28 14:30:34 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 15:01:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362333002/40001
5 years, 2 months ago (2015-09-28 15:05:36 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 15:09:49 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b466dc14791844b7ae6d1e9ebd00a778965c206d Cr-Commit-Position: refs/heads/master@{#30981}
5 years, 2 months ago (2015-09-28 15:10:02 UTC) #19
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1379513002/ by machenbach@chromium.org. ...
5 years, 2 months ago (2015-09-29 04:52:55 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362333002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362333002/80001
5 years, 2 months ago (2015-09-30 11:53:11 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 12:15:57 UTC) #24 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698