Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362323002: Removing unused method FtpNetworkLayer::CreateFactory (Closed)

Created:
5 years, 3 months ago by Paritosh Kumar
Modified:
5 years, 2 months ago
Reviewers:
asanka
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused method FtpNetworkLayer::CreateFactory BUG= Committed: https://crrev.com/304e943833c0df218ba69f54230619987078f7c9 Cr-Commit-Position: refs/heads/master@{#351347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M net/ftp/ftp_network_layer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_layer.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Paritosh Kumar
Please have a look.
5 years, 2 months ago (2015-09-28 05:30:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362323002/1
5 years, 2 months ago (2015-09-28 22:25:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 23:42:47 UTC) #6
asanka
lgtm
5 years, 2 months ago (2015-09-29 04:30:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362323002/1
5 years, 2 months ago (2015-09-29 17:38:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 17:52:27 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 17:53:32 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/304e943833c0df218ba69f54230619987078f7c9
Cr-Commit-Position: refs/heads/master@{#351347}

Powered by Google App Engine
This is Rietveld 408576698