Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1362313002: X87: [es6] Introduce spec compliant IsConstructor. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Introduce spec compliant IsConstructor. port 8fe3ac07014ce5891be0a1cbd8019e9f3b02ff0b (30902). original commit message: There was already a bit on the Map named "function with prototype", which basically meant that the Map was a map for a JSFunction that could be used as a constructor. Now this CL generalizes that bit to IsConstructor, which says that whatever (Heap)Object you are looking at can be used as a constructor (i.e. the bit is also set for bound functions that can be used as constructors and proxies that have a [[Construct]] internal method). This way we have a single chokepoint for IsConstructor checking, which allows us to get rid of the various ways in which we tried to guess whether something could be used as a constructor or not. Drive-by-fix: Renamed IsConstructor on FunctionKind to IsClassConstructor to resolve the weird name clash, and the IsClassConstructor name also matches the spec. BUG= Committed: https://crrev.com/11fd60f5a9b5925843fe2160025f1fd8b68cf9c8 Cr-Commit-Position: refs/heads/master@{#30908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +38 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-24 10:11:00 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 10:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362313002/1
5 years, 3 months ago (2015-09-24 10:15:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 10:46:10 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 10:46:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11fd60f5a9b5925843fe2160025f1fd8b68cf9c8
Cr-Commit-Position: refs/heads/master@{#30908}

Powered by Google App Engine
This is Rietveld 408576698