Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1362293002: X87: [builtin] Refactor Invoke to deal with any kind of callable. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtin] Refactor Invoke to deal with any kind of callable. port 634d1d86d8e98584097c6cb548a68ecf705c44f7 (r30874). original commit message: Now both Execution::Call and Execution::New can deal with any kind of target and will raise a proper exception if the target is not callable (which is not yet spec compliant for New, as we would have to check IsConstructor instead, which we don't have yet). Now we no longer need to do any of these weird call/construct delegate gymnastics in C++, and we finally have a single true bottleneck for Call/Construct abstract operations in the code base, with only a few special handlings left in the compilers to optimize the JSFunction case. BUG= Committed: https://crrev.com/78be1562e4a64d74d99297ad60e232280a9855b3 Cr-Commit-Position: refs/heads/master@{#30904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-24 08:22:29 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 08:32:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362293002/1
5 years, 3 months ago (2015-09-24 08:32:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 08:58:26 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 08:58:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78be1562e4a64d74d99297ad60e232280a9855b3
Cr-Commit-Position: refs/heads/master@{#30904}

Powered by Google App Engine
This is Rietveld 408576698