Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1362283003: Make toPositionInComposedTree() with non-distributed node to return non-null position (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, yoichio
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make toPositionInComposedTree() with non-distributed node to return non-null position This patch makes |toPositionInComposedTree()| with a position at non-distributed node to return a position after children in shadow host rather than null position. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=513568 TEST=PositionTest.ToPositionInComposedTreeWithNotDistributed Committed: https://crrev.com/18f60f0b43d791ca4b2c90cbcf7f49dfde1cc46c Cr-Commit-Position: refs/heads/master@{#350741}

Patch Set 1 : 2015-09-24T18:07:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/Position.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-24 12:32:06 UTC) #2
tkent
rs lgtm
5 years, 2 months ago (2015-09-25 01:02:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362283003/1
5 years, 2 months ago (2015-09-25 01:19:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 01:40:09 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 01:40:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18f60f0b43d791ca4b2c90cbcf7f49dfde1cc46c
Cr-Commit-Position: refs/heads/master@{#350741}

Powered by Google App Engine
This is Rietveld 408576698