Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1362243002: mojo: Add proper implementation of DetachFromClient to OutputSurfaceMojo. (Closed)

Created:
5 years, 3 months ago by reveman
Modified:
5 years, 3 months ago
Reviewers:
msw, sky, piman
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Add proper implementation of DetachFromClient to OutputSurfaceMojo. BUG=523411, 525811 TBR=sky@chromium.org TEST=mojo_runner --use-temporary-user-data-dir --enable-html-viewer-test-interface --use-x11-test-config --override-use-gl-with-osmesa-for-tests --gtest_filter=AXProviderTest.HelloWorld mojo:html_viewer_apptests NOTRY=true Committed: https://crrev.com/18167629b4bdc20e951b71e9c546ed0c1030090f Cr-Commit-Position: refs/heads/master@{#350483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reveman
5 years, 3 months ago (2015-09-24 04:58:43 UTC) #2
reveman
I think we can land this without going through the try bots. Verified that it ...
5 years, 3 months ago (2015-09-24 05:00:15 UTC) #3
msw
lgtm, thanks!
5 years, 3 months ago (2015-09-24 05:02:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362243002/1
5 years, 3 months ago (2015-09-24 05:03:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 05:10:10 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 05:10:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18167629b4bdc20e951b71e9c546ed0c1030090f
Cr-Commit-Position: refs/heads/master@{#350483}

Powered by Google App Engine
This is Rietveld 408576698