chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js ('k') | chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js

diff --git a/chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js b/chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js

index eb548a319e20965405a555b272430804be69324f..5e31345c5b6ced3d668fbdbf7d3710310848ae4d 100644

--- a/chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js

+++ b/chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js

@@ -10,6 +10,7 @@

goog.provide('cvox.AbstractTts');

+goog.require('Msgs');

goog.require('cvox.TtsInterface');

goog.require('goog.i18n.MessageFormat');

@@ -238,7 +239,7 @@ cvox.AbstractTts.prototype.preprocess = function(text, properties) {

// Handle single characters that we want to make sure we pronounce.

if (text.length == 1) {

return cvox.AbstractTts.CHARACTER_DICTIONARY[text] ?

- (new goog.i18n.MessageFormat(cvox.ChromeVox.msgs.getMsg(

+ (new goog.i18n.MessageFormat(Msgs.getMsg(

cvox.AbstractTts.CHARACTER_DICTIONARY[text])))

.format({'COUNT': 1}) :

text.toUpperCase();

@@ -552,7 +553,7 @@ cvox.AbstractTts.repetitionRegexp_ =

cvox.AbstractTts.repetitionReplace_ = function(match) {

var count = match.length;

- return ' ' + (new goog.i18n.MessageFormat(cvox.ChromeVox.msgs.getMsg(

+ return ' ' + (new goog.i18n.MessageFormat(Msgs.getMsg(

cvox.AbstractTts.CHARACTER_DICTIONARY[match[0]])))

.format({'COUNT': count}) + ' ';

};