chrome/browser/resources/chromeos/chromevox/common/description_util.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/description_util.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/date_widget.js ('k') | chrome/browser/resources/chromeos/chromevox/common/dom_util.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/description_util.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/description_util.js b/chrome/browser/resources/chromeos/chromevox/common/description_util.js

index 0b8f255fbe445953e913637b88554565deb7f4fc..d7bece47b98326280cc4cff73ed232f23388c00a 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/description_util.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/description_util.js

@@ -216,7 +216,7 @@ cvox.DescriptionUtil.getDescriptionFromNavigation =

prevAncestors, recursive, verbosity);

if (prevDesc.context && !desc.context) {

desc.context =

- cvox.ChromeVox.msgs.getMsg('exited_container', [prevDesc.context]);

+ Msgs.getMsg('exited_container', [prevDesc.context]);

}

return [desc];

@@ -376,10 +376,10 @@ cvox.DescriptionUtil.insertCollectionDescription_ = function(descriptions) {

descriptions.splice(0, 0, new cvox.NavDescription({

context: firstContext,

text: '',

- annotation: cvox.ChromeVox.msgs.getMsg(

+ annotation: Msgs.getMsg(

'collection',

[commonAnnotation,

- cvox.ChromeVox.msgs.getNumber(descriptions.length)])

+ Msgs.getNumber(descriptions.length)])

}));

}

};

@@ -399,7 +399,7 @@ cvox.DescriptionUtil.getAnnotations_ = function(descriptions) {

// If we have an Internal link collection, call it Link collection.

// NOTE(deboer): The message comparison is a symptom of a bad design.

// I suspect this code belongs elsewhere but I don't know where, yet.

- var linkMsg = cvox.ChromeVox.msgs.getMsg('tag_link');

+ var linkMsg = Msgs.getMsg('role_link');

if (description.annotation.toLowerCase().indexOf(linkMsg.toLowerCase()) !=

-1) {

if (annotations.indexOf(linkMsg) == -1) {

@@ -427,7 +427,7 @@ cvox.DescriptionUtil.getAnnotations_ = function(descriptions) {

* @private

cvox.DescriptionUtil.isAnnotationCollection_ = function(annotation) {

- return (annotation == cvox.ChromeVox.msgs.getMsg('tag_link'));

+ return (annotation == Msgs.getMsg('role_link'));

};

/**