Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5553)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/command_store.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception
Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/common/command_store.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/command_store.js b/chrome/browser/resources/chromeos/chromevox/common/command_store.js
index d50fe47b9d869514f4945b47f7e2cec42ed7166d..05e0273193397fffe5774c21b0f7ccd5a39a8d7d 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/command_store.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/command_store.js
@@ -688,15 +688,15 @@ cvox.CommandStore.NODE_INFO_MAP = {
'checkbox': {predicate: 'checkboxPredicate',
forwardError: 'no_next_checkbox',
backwardError: 'no_previous_checkbox',
- typeMsg: 'aria_role_checkbox'},
+ typeMsg: 'role_checkbox'},
'radio': {predicate: 'radioPredicate',
forwardError: 'no_next_radio_button',
backwardError: 'no_previous_radio_button',
- typeMsg: 'aria_role_radio'},
+ typeMsg: 'role_radio'},
'slider': {predicate: 'sliderPredicate',
forwardError: 'no_next_slider',
backwardError: 'no_previous_slider',
- typeMsg: 'aria_role_slider'},
+ typeMsg: 'role_slider'},
'graphic': {predicate: 'graphicPredicate',
forwardError: 'no_next_graphic',
backwardError: 'no_previous_graphic',
@@ -708,11 +708,11 @@ cvox.CommandStore.NODE_INFO_MAP = {
'button': {predicate: 'buttonPredicate',
forwardError: 'no_next_button',
backwardError: 'no_previous_button',
- typeMsg: 'aria_role_button'},
+ typeMsg: 'role_button'},
'combobox': {predicate: 'comboBoxPredicate',
forwardError: 'no_next_combo_box',
backwardError: 'no_previous_combo_box',
- typeMsg: 'aria_role_combobox'},
+ typeMsg: 'role_combobox'},
'editText': {predicate: 'editTextPredicate',
forwardError: 'no_next_edit_text',
backwardError: 'no_previous_edit_text',
@@ -720,7 +720,7 @@ cvox.CommandStore.NODE_INFO_MAP = {
'heading': {predicate: 'headingPredicate',
forwardError: 'no_next_heading',
backwardError: 'no_previous_heading',
- typeMsg: 'aria_role_heading'},
+ typeMsg: 'role_heading'},
'heading1': {predicate: 'heading1Predicate',
forwardError: 'no_next_heading_1',
backwardError: 'no_previous_heading_1'},
@@ -743,7 +743,7 @@ cvox.CommandStore.NODE_INFO_MAP = {
'link': {predicate: 'linkPredicate',
forwardError: 'no_next_link',
backwardError: 'no_previous_link',
- typeMsg: 'aria_role_link'},
+ typeMsg: 'role_link'},
'table': {predicate: 'tablePredicate',
forwardError: 'no_next_table',
backwardError: 'no_previous_table',
@@ -751,19 +751,19 @@ cvox.CommandStore.NODE_INFO_MAP = {
'visitedLink': {predicate: 'visitedLinkPredicate',
forwardError: 'no_next_visited_link',
backwardError: 'no_previous_visited_link',
- typeMsg: 'tag_link'},
+ typeMsg: 'role_link'},
'list': {predicate: 'listPredicate',
forwardError: 'no_next_list',
backwardError: 'no_previous_list',
- typeMsg: 'aria_role_list'},
+ typeMsg: 'role_list'},
'listItem': {predicate: 'listItemPredicate',
forwardError: 'no_next_list_item',
backwardError: 'no_previous_list_item',
- typeMsg: 'aria_role_listitem'},
+ typeMsg: 'role_listitem'},
'formField': {predicate: 'formFieldPredicate',
forwardError: 'no_next_form_field',
backwardError: 'no_previous_form_field',
- typeMsg: 'aria_role_form'},
+ typeMsg: 'role_form'},
'landmark': {predicate: 'landmarkPredicate',
forwardError: 'no_next_landmark',
backwardError: 'no_previous_landmark',

Powered by Google App Engine
This is Rietveld 408576698