chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/braille_util.js ('k') | chrome/browser/resources/chromeos/chromevox/common/chromevox.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

diff --git a/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs b/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

index a1ee77ff9f44c3e59289f9cd834ed9a577a2982f..be935d5df4884df5337070d98638a563cffc21a2 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

+++ b/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs

@@ -20,12 +20,12 @@ CvoxBrailleUtilUnitTest.prototype = {

'cvox.BrailleUtil',

'cvox.CursorSelection',

'cvox.NavigationShifter',

- 'cvox.TestMsgs',

+ 'TestMsgs',

/** @override */

setUp: function() {

- cvox.ChromeVox.msgs = new cvox.TestMsgs();

+ Msgs = TestMsgs;

/**

@@ -359,12 +359,12 @@ TEST_F('CvoxBrailleUtilUnitTest', 'GetTemplatedOverride', function() {

assertEquals('Menu mnu',

cvox.BrailleUtil.getTemplated(null, null,

{ 'name': 'Menu',

- 'roleMsg': 'aria_role_menu' }).

+ 'roleMsg': 'role_menu' }).

toString());

assertEquals('alrt: Watch out!',

cvox.BrailleUtil.getTemplated(null, null,

{ 'name': 'Watch out!',

- 'roleMsg': 'aria_role_alert' }).

+ 'roleMsg': 'role_alert' }).

toString());

// Test all properties. role, if present, overrides roleMsg.

assertEquals('Name Value Role State',