chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/node_search_widget.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/select_widget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js

index fec7fb1f88f44299e350fcd22d1483e1aa5e9747..410813aaed03f9533c1ec4a4fa7eb7466cf00300 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js

@@ -323,12 +323,12 @@ cvox.SearchWidget.prototype.toggleCaseSensitivity_ = function() {

if (this.caseSensitive_) {

cvox.SearchWidget.caseSensitive_ = false;

cvox.ChromeVox.tts.speak(

- cvox.ChromeVox.msgs.getMsg('ignoring_case'),

+ Msgs.getMsg('ignoring_case'),

cvox.QueueMode.FLUSH, null);

} else {

this.caseSensitive_ = true;

cvox.ChromeVox.tts.speak(

- cvox.ChromeVox.msgs.getMsg('case_sensitive'),

+ Msgs.getMsg('case_sensitive'),

cvox.QueueMode.FLUSH, null);

}

};

@@ -462,7 +462,7 @@ cvox.SearchWidget.prototype.outputSearchResult_ = function(result, searchStr) {

null,

cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);

- cvox.ChromeVox.tts.speak(cvox.ChromeVox.msgs.getMsg('search_help_item'),

+ cvox.ChromeVox.tts.speak(Msgs.getMsg('search_help_item'),

cvox.QueueMode.QUEUE,

cvox.AbstractTts.PERSONALITY_ANNOTATION);

@@ -499,7 +499,7 @@ cvox.SearchWidget.prototype.outputSearchResultToBraille_ = function(searchStr) {

// Mark the string as a search result by adding a prefix

// and adjust the targetIndex accordingly.

var oldLength = text.length;

- text = cvox.ChromeVox.msgs.getMsg('mark_as_search_result_brl', [text]);

+ text = Msgs.getMsg('mark_as_search_result_brl', [text]);

var newLength = text.length;

targetIndex += (newLength - oldLength);