chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_shifter.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

index 387bc2fa45b601afd0c00b0d98649983aba6b9be..a7ed82ff6d02d2166edc72aae42b86ca577e3c4d 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

@@ -390,7 +390,7 @@ cvox.NavigationManager.prototype.syncAll = function(opt_skipText) {

cvox.NavigationManager.prototype.clearPageSel = function(opt_announce) {

var hasSel = !!this.pageSel_;

if (hasSel && opt_announce) {

- var announcement = cvox.ChromeVox.msgs.getMsg('clear_page_selection');

+ var announcement = Msgs.getMsg('clear_page_selection');

cvox.ChromeVox.tts.speak(announcement, cvox.QueueMode.FLUSH,

cvox.AbstractTts.PERSONALITY_ANNOTATION);

}

@@ -703,9 +703,9 @@ cvox.NavigationManager.prototype.finishNavCommand = function(

cvox.ChromeVox.tts.stop();

cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.WRAP);

if (cvox.ChromeVox.verbosity === cvox.VERBOSITY_VERBOSE) {

- var msg = cvox.ChromeVox.msgs.getMsg('wrapped_to_top');

+ var msg = Msgs.getMsg('wrapped_to_top');

if (this.isReversed()) {

- msg = cvox.ChromeVox.msgs.getMsg('wrapped_to_bottom');

+ msg = Msgs.getMsg('wrapped_to_bottom');

}

cvox.ChromeVox.tts.speak(msg, cvox.QueueMode.QUEUE,

cvox.AbstractTts.PERSONALITY_ANNOTATION);

@@ -714,8 +714,7 @@ cvox.NavigationManager.prototype.finishNavCommand = function(

}

if (this.enteredShifter_ || this.exitedShifter_) {

- opt_prefix = cvox.ChromeVox.msgs.getMsg(

- 'enter_content_say', [this.shifter_.getName()]);

+ opt_prefix = Msgs.getMsg('enter_content_say', [this.shifter_.getName()]);

}

var descriptionArray = cvox.ChromeVox.navigationManager.getDescription();