chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_globals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

index d4c228cb8acb10af62f0b51efeaf4ee248b22063..f27e3e7371931396430561a977d57f29ed446e88 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

@@ -519,7 +519,7 @@ cvox.ChromeVoxEventWatcher.mouseClickEventWatcher = function(evt) {

// happens in a focused text field).

cvox.Focuser.setFocus(cvox.ChromeVox.navigationManager.getCurrentNode());

cvox.ChromeVox.tts.speak(

- cvox.ChromeVox.msgs.getMsg('element_clicked'),

+ Msgs.getMsg('element_clicked'),

cvox.ChromeVoxEventWatcher.queueMode_(),

cvox.AbstractTts.PERSONALITY_ANNOTATION);

var targetNode = cvox.ChromeVox.navigationManager.getCurrentNode();

@@ -887,7 +887,7 @@ cvox.ChromeVoxEventWatcher.clipboardEventWatcher = function(evt) {

return true;

}

- cvox.ChromeVox.tts.speak(cvox.ChromeVox.msgs.getMsg(evt.type).toLowerCase(),

+ cvox.ChromeVox.tts.speak(Msgs.getMsg(evt.type).toLowerCase(),

cvox.QueueMode.QUEUE);

var text = '';

switch (evt.type) {

@@ -1248,7 +1248,7 @@ cvox.ChromeVoxEventWatcher.handleDialogFocus = function(target) {

cvox.ChromeVox.navigationManager.currentDialog = null;

cvox.ChromeVoxEventWatcher.speakAnnotationWithCategory_(

- cvox.ChromeVox.msgs.getMsg('exiting_dialog'),

+ Msgs.getMsg('exiting_dialog'),

cvox.TtsCategory.NAV);

return true;

}

@@ -1256,7 +1256,7 @@ cvox.ChromeVoxEventWatcher.handleDialogFocus = function(target) {

if (dialog) {

cvox.ChromeVox.navigationManager.currentDialog = dialog;

cvox.ChromeVoxEventWatcher.speakAnnotationWithCategory_(

- cvox.ChromeVox.msgs.getMsg('entering_dialog'),

+ Msgs.getMsg('entering_dialog'),

cvox.TtsCategory.NAV);

if (role == 'alertdialog') {