chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js » ('j') | chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js b/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

index c323d8020b0acb9bba5c12204c7211186977f519..d4f1676e00a93ae9a0dbccd56d9cea8215e0aea6 100644

--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

@@ -133,7 +133,7 @@ cvox.TtsBackground = function(opt_enableMath) {

* @const

this.PHONETIC_MAP_ = /** @type {Object<string>} */(

- JSON.parse(cvox.ChromeVox.msgs.getMsg('phonetic_map')));

+ JSON.parse(Msgs.getMsg('phonetic_map')));

} catch (e) {

console.log('Error; unable to parse phonetic map msg.');

}

@@ -646,7 +646,7 @@ cvox.TtsBackground.prototype.createPunctuationReplace_ = function(clear) {

var retain = this.retainPunctuation_.indexOf(match) != -1 ?

match : ' ';

return clear ? retain :

- ' ' + (new goog.i18n.MessageFormat(cvox.ChromeVox.msgs.getMsg(

+ ' ' + (new goog.i18n.MessageFormat(Msgs.getMsg(

cvox.AbstractTts.CHARACTER_DICTIONARY[match])))

.format({'COUNT': 1}) + retain + ' ';

}, this);