Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/aria_util.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/common/aria_util.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/aria_util.js b/chrome/browser/resources/chromeos/chromevox/common/aria_util.js
index 734a5bbc843c88d7f2df28c367d9ce89d7ba2900..2dfbc7064e55e95c2c50d94e4031a2476cbb3966 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/aria_util.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/aria_util.js
@@ -40,7 +40,7 @@ cvox.AriaUtil.WIDGET_ROLE_TO_NAME = {
'dialog' : 'aria_role_dialog',
'grid' : 'aria_role_grid',
'gridcell' : 'aria_role_gridcell',
- 'link' : 'aria_role_link',
+ 'link' : 'tag_link',
dmazzoni 2015/09/25 16:23:35 Slightly confusing to me because the tag name for
'listbox' : 'aria_role_listbox',
'log' : 'aria_role_log',
'marquee' : 'aria_role_marquee',
@@ -345,7 +345,7 @@ cvox.AriaUtil.getRoleNameMsg = function(targetNode) {
*/
cvox.AriaUtil.getRoleName = function(targetNode) {
var roleMsg = cvox.AriaUtil.getRoleNameMsg(targetNode);
- var roleName = cvox.ChromeVox.msgs.getMsg(roleMsg);
+ var roleName = Msgs.getMsg(roleMsg);
var role = cvox.AriaUtil.getRoleAttribute(targetNode);
if ((role == 'heading') && (targetNode.hasAttribute('aria-level'))) {
roleName += ' ' + targetNode.getAttribute('aria-level');

Powered by Google App Engine
This is Rietveld 408576698