Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/walkers/structural_line_walker.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception
Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A JavaScript class for walking lines. 6 * @fileoverview A JavaScript class for walking lines.
7 */ 7 */
8 8
9 9
10 goog.provide('cvox.StructuralLineWalker'); 10 goog.provide('cvox.StructuralLineWalker');
(...skipping 10 matching lines...) Expand all
21 goog.base(this); 21 goog.base(this);
22 this.grain = cvox.TraverseContent.kLine; 22 this.grain = cvox.TraverseContent.kLine;
23 }; 23 };
24 goog.inherits(cvox.StructuralLineWalker, cvox.AbstractSelectionWalker); 24 goog.inherits(cvox.StructuralLineWalker, cvox.AbstractSelectionWalker);
25 25
26 26
27 /** 27 /**
28 * @override 28 * @override
29 */ 29 */
30 cvox.StructuralLineWalker.prototype.getGranularityMsg = function() { 30 cvox.StructuralLineWalker.prototype.getGranularityMsg = function() {
31 return cvox.ChromeVox.msgs.getMsg('structural_line'); 31 return Msgs.getMsg('structural_line');
32 }; 32 };
33 33
34 34
35 /** 35 /**
36 * @override 36 * @override
37 */ 37 */
38 cvox.StructuralLineWalker.prototype.getDescription = function(prevSel, sel) { 38 cvox.StructuralLineWalker.prototype.getDescription = function(prevSel, sel) {
39 var desc = goog.base(this, 'getDescription', prevSel, sel); 39 var desc = goog.base(this, 'getDescription', prevSel, sel);
40 desc[0].text = cvox.DomUtil.getPrefixText( 40 desc[0].text = cvox.DomUtil.getPrefixText(
41 sel.absStart().node, sel.absStart().index) + desc[0].text; 41 sel.absStart().node, sel.absStart().index) + desc[0].text;
(...skipping 27 matching lines...) Expand all
69 var spannable = 69 var spannable =
70 cvox.BrailleUtil.getTemplated(prevNode, objNode, {name: name}); 70 cvox.BrailleUtil.getTemplated(prevNode, objNode, {name: name});
71 spannable.setSpan(objNode, 0, spannable.getLength()); 71 spannable.setSpan(objNode, 0, spannable.getLength());
72 braille.text = spannable; 72 braille.text = spannable;
73 73
74 // Remove any selections. 74 // Remove any selections.
75 braille.startIndex = 0; 75 braille.startIndex = 0;
76 braille.endIndex = 0; 76 braille.endIndex = 0;
77 return braille; 77 return braille;
78 }; 78 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698