Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception
Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A JavaScript class for walking lines consisting of one or more 6 * @fileoverview A JavaScript class for walking lines consisting of one or more
7 * clickable nodes. 7 * clickable nodes.
8 */ 8 */
9 9
10 10
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 this.appendBraille_(prevSel, absSel, cur, braille); 123 this.appendBraille_(prevSel, absSel, cur, braille);
124 } 124 }
125 return braille; 125 return braille;
126 }; 126 };
127 127
128 128
129 /** 129 /**
130 * @override 130 * @override
131 */ 131 */
132 cvox.LayoutLineWalker.prototype.getGranularityMsg = function() { 132 cvox.LayoutLineWalker.prototype.getGranularityMsg = function() {
133 return cvox.ChromeVox.msgs.getMsg('layout_line'); 133 return Msgs.getMsg('layout_line');
134 }; 134 };
135 135
136 136
137 /** 137 /**
138 * Compares two selections and determines if the lie on the same horizontal 138 * Compares two selections and determines if the lie on the same horizontal
139 * line as determined by their bounding rectangles. 139 * line as determined by their bounding rectangles.
140 * @param {!cvox.CursorSelection} lSel Left selection. 140 * @param {!cvox.CursorSelection} lSel Left selection.
141 * @param {!cvox.CursorSelection} rSel Right selection. 141 * @param {!cvox.CursorSelection} rSel Right selection.
142 * @return {boolean} Whether lSel and rSel are on different visual lines. 142 * @return {boolean} Whether lSel and rSel are on different visual lines.
143 * @private 143 * @private
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 if (sel && cur.absEquals(sel)) { 236 if (sel && cur.absEquals(sel)) {
237 if (valueSelectionSpan) { 237 if (valueSelectionSpan) {
238 braille.startIndex = nodeStart + item.getSpanStart(valueSelectionSpan); 238 braille.startIndex = nodeStart + item.getSpanStart(valueSelectionSpan);
239 braille.endIndex = nodeStart + item.getSpanEnd(valueSelectionSpan); 239 braille.endIndex = nodeStart + item.getSpanEnd(valueSelectionSpan);
240 } else { 240 } else {
241 braille.startIndex = nodeStart; 241 braille.startIndex = nodeStart;
242 braille.endIndex = nodeStart + 1; 242 braille.endIndex = nodeStart + 1;
243 } 243 }
244 } 244 }
245 }; 245 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698