Improve braille related message descriptions and clean up message handling in Chromevox.

chrome/browser/resources/chromeos/chromevox/common/aria_util.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A collection of JavaScript utilities used to simplify working
  * with ARIA (http://www.w3.org/TR/wai-aria).
  */
 
 
@@ skipping 22 matching lines @@
 cvox.AriaUtil.WIDGET_ROLE_TO_NAME = {
   'alert' : 'aria_role_alert',
   'alertdialog' : 'aria_role_alertdialog',
   'button' : 'aria_role_button',
   'checkbox' : 'aria_role_checkbox',
   'columnheader' : 'aria_role_columnheader',
   'combobox' : 'aria_role_combobox',
   'dialog' : 'aria_role_dialog',
   'grid' : 'aria_role_grid',
   'gridcell' : 'aria_role_gridcell',
-  'link' : 'aria_role_link',
+  'link' : 'tag_link',

[dmazzoni, 2015/09/25 16:23:35]

Slightly confusing to me because the tag name for a hyperlink isn't "link", and
there is a <link> tag that means something else

What about getting rid of the "aria_" from most of the messages for role names?
role_link is totally clear, and there are a few other cases where we have a role
that can come from an ARIA role or from native HTML.

   'listbox' : 'aria_role_listbox',
   'log' : 'aria_role_log',
   'marquee' : 'aria_role_marquee',
   'menu' : 'aria_role_menu',
   'menubar' : 'aria_role_menubar',
   'menuitem' : 'aria_role_menuitem',
   'menuitemcheckbox' : 'aria_role_menuitemcheckbox',
   'menuitemradio' : 'aria_role_menuitemradio',
   'option' : 'aria_role_option',
   'progressbar' : 'aria_role_progressbar',
@@ skipping 284 matching lines @@
 
 /**
  * Returns a string to be presented to the user that identifies what the
  * targetNode's role is.
  *
  * @param {Node} targetNode The node to get the role name for.
  * @return {string} The role name for the targetNode.
  */
 cvox.AriaUtil.getRoleName = function(targetNode) {
   var roleMsg = cvox.AriaUtil.getRoleNameMsg(targetNode);
-  var roleName = cvox.ChromeVox.msgs.getMsg(roleMsg);
+  var roleName = Msgs.getMsg(roleMsg);
   var role = cvox.AriaUtil.getRoleAttribute(targetNode);
   if ((role == 'heading') && (targetNode.hasAttribute('aria-level'))) {
     roleName += ' ' + targetNode.getAttribute('aria-level');
   }
   return roleName ? roleName : '';
 };
 
 /**
  * Returns a string that gives information about the state of the targetNode.
  *
@@ skipping 610 matching lines @@
  * @param {Node} node The node to be checked.
  * @return {boolean} Whether or not the node is an ARIA math node.
  */
 cvox.AriaUtil.isMath = function(node) {
   if (!node || !node.getAttribute) {
     return false;
   }
   var role = cvox.AriaUtil.getRoleAttribute(node);
   return role == 'math';
 };