Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362223002: Cleanup: Remove references to tests that no longer exists / are unused. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
brettw, Jamie
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, serviceworker-reviews, bondd+autofillwatch_chromium.org, horo+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, melevin+watch_chromium.org, chromoting-reviews_chromium.org, jam, kinuko+serviceworker, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, blink-worker-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, jsbell+serviceworker_chromium.org, rouslan+autofill_chromium.org, nhiroki, jfweitz+watch_chromium.org, kalyank, Jered, michaeln, tfarina, donnd+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, David Black, samarth+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove references to tests that no longer exists / are unused. Committed: https://crrev.com/92619caa27a1b8aca56b46b0e25fbf2b85a02898 Cr-Commit-Position: refs/heads/master@{#350630}

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -171 lines) Patch
M ash/wm/overlay_event_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/prefs/pref_value_store.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/background/background_contents_service.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/search/most_visited_iframe_source_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/sticky_settings.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_syncable_service.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M components/translate/content/renderer/translate_helper.h View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 4 chunks +12 lines, -14 lines 0 comments Download
M crypto/rsa_private_key.h View 1 4 chunks +9 lines, -20 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 2 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
Today's "recharge" meant I triaged a lot of bugs, and some of them referred to ...
5 years, 3 months ago (2015-09-24 03:34:13 UTC) #2
Jamie
remoting/ LGTM.
5 years, 3 months ago (2015-09-24 16:52:51 UTC) #4
brettw
lgtm
5 years, 3 months ago (2015-09-24 18:33:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362223002/40001
5 years, 3 months ago (2015-09-24 19:18:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-24 19:53:30 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 19:55:59 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/92619caa27a1b8aca56b46b0e25fbf2b85a02898
Cr-Commit-Position: refs/heads/master@{#350630}

Powered by Google App Engine
This is Rietveld 408576698