Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 1362143002: Flip conditionals to positive logic in pdfium_test. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flip conditionals to positive logic in pdfium_test. Also merge a check for failed document loads from XFA. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c4e940d803113552a146cd059b1ca793a1f72a22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M samples/pdfium_test.cc View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 3 months ago (2015-09-23 21:57:40 UTC) #2
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-23 22:07:26 UTC) #3
Lei Zhang
5 years, 3 months ago (2015-09-23 22:10:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4e940d803113552a146cd059b1ca793a1f72a22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698