Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1362053003: Avoid last param to CTFontCreateWithGraphicsFont. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid last param to CTFontCreateWithGraphicsFont. The last parameter of CTFontCreateWithGraphicsFont (CTFontDescriptorRef attributes) *must* be nullptr. If non-nullptr then with fonts with variation axes, the copy will fail in CGFontVariationFromDictCallback when it assumes kCGFontVariationAxisName is CFNumberRef which it quite obviously is not. TBR=reed@google.com Blocking dev builds, just removes code. BUG=chromium:535109 Committed: https://skia.googlesource.com/skia/+/0584631f5254add2f85d94f788d9d6115509211e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -56 lines) Patch
M src/ports/SkFontHost_mac.cpp View 4 chunks +18 lines, -56 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362053003/1
5 years, 3 months ago (2015-09-23 18:02:13 UTC) #2
bungeman-skia
Unsurprisingly the work around for the issue in CoreText uncovered what appears to be a ...
5 years, 3 months ago (2015-09-23 18:10:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-23 18:35:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362053003/1
5 years, 3 months ago (2015-09-23 19:50:47 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 19:51:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0584631f5254add2f85d94f788d9d6115509211e

Powered by Google App Engine
This is Rietveld 408576698