Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/extensions/chrome_extensions_browser_client.h

Issue 1362043005: Add extensions code to use common updater in components/update_client/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: responded to review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <string>
9 #include <vector>
9 10
10 #include "base/basictypes.h" 11 #include "base/basictypes.h"
11 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
12 #include "base/lazy_instance.h" 13 #include "base/lazy_instance.h"
13 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
Sorin Jianu 2015/10/02 00:05:10 iwyu, memory/ref_counted.h
asargent_no_longer_on_chrome 2015/10/06 21:31:17 Done.
14 #include "chrome/browser/extensions/chrome_notification_observer.h" 15 #include "chrome/browser/extensions/chrome_notification_observer.h"
15 #include "extensions/browser/extensions_browser_client.h" 16 #include "extensions/browser/extensions_browser_client.h"
16 17
17 namespace base { 18 namespace base {
18 class CommandLine; 19 class CommandLine;
19 } 20 }
20 21
21 namespace content { 22 namespace content {
22 class BrowserContext; 23 class BrowserContext;
23 } 24 }
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 bool IsMinBrowserVersionSupported(const std::string& min_version) override; 104 bool IsMinBrowserVersionSupported(const std::string& min_version) override;
104 ExtensionWebContentsObserver* GetExtensionWebContentsObserver( 105 ExtensionWebContentsObserver* GetExtensionWebContentsObserver(
105 content::WebContents* web_contents) override; 106 content::WebContents* web_contents) override;
106 void ReportError(content::BrowserContext* context, 107 void ReportError(content::BrowserContext* context,
107 scoped_ptr<ExtensionError> error) override; 108 scoped_ptr<ExtensionError> error) override;
108 void CleanUpWebView(content::BrowserContext* browser_context, 109 void CleanUpWebView(content::BrowserContext* browser_context,
109 int embedder_process_id, 110 int embedder_process_id,
110 int view_instance_id) override; 111 int view_instance_id) override;
111 void AttachExtensionTaskManagerTag(content::WebContents* web_contents, 112 void AttachExtensionTaskManagerTag(content::WebContents* web_contents,
112 ViewType view_type) override; 113 ViewType view_type) override;
114 scoped_refptr<update_client::UpdateClient> CreateUpdateClient(
Sorin Jianu 2015/10/02 00:05:10 Is update_client::UpdateClient declared anywhere?
asargent_no_longer_on_chrome 2015/10/06 21:31:17 It's forward-declared in extensions/browser/extens
Sorin Jianu 2015/10/08 22:57:54 Acknowledged.
115 content::BrowserContext* context) override;
113 116
114 private: 117 private:
115 friend struct base::DefaultLazyInstanceTraits<ChromeExtensionsBrowserClient>; 118 friend struct base::DefaultLazyInstanceTraits<ChromeExtensionsBrowserClient>;
116 119
117 // Observer for Chrome-specific notifications. 120 // Observer for Chrome-specific notifications.
118 ChromeNotificationObserver notification_observer_; 121 ChromeNotificationObserver notification_observer_;
119 122
120 // Support for ProcessManager. 123 // Support for ProcessManager.
121 scoped_ptr<ChromeProcessManagerDelegate> process_manager_delegate_; 124 scoped_ptr<ChromeProcessManagerDelegate> process_manager_delegate_;
122 125
123 // Client for API implementations. 126 // Client for API implementations.
124 scoped_ptr<ChromeExtensionsAPIClient> api_client_; 127 scoped_ptr<ChromeExtensionsAPIClient> api_client_;
125 128
126 scoped_ptr<ChromeComponentExtensionResourceManager> resource_manager_; 129 scoped_ptr<ChromeComponentExtensionResourceManager> resource_manager_;
127 130
128 scoped_ptr<ExtensionCache> extension_cache_; 131 scoped_ptr<ExtensionCache> extension_cache_;
129 132
130 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsBrowserClient); 133 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsBrowserClient);
131 }; 134 };
132 135
133 } // namespace extensions 136 } // namespace extensions
134 137
135 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_ 138 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698