Add extensions code to use common updater in components/update_client/

chrome/browser/extensions/chrome_extensions_browser_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_
 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_
 
 #include <map>
+#include <string>

[Ken Rockot(use gerrit already), 2015/09/25 16:19:19]

I would argue that these are unnecessary since the only references to
std::string and std::vector are for method signatures overridden from
ExtensionsBrowserClient, and it should be safe for a derived class to assume the
base has already provided necessary definitions (and extensions_browser_client.h
does in fact include these headers).

On a related note, it looks like <map> actually isn't used at all now, so that
could be deleted too!

[asargent_no_longer_on_chrome, 2015/09/29 22:59:21]

Removed <map>. As for the <string> and <vector> includes, I just added it to get
a clean run of 'git cl lint', where the IncludeWhatYouUse rule likely doesn't
know about inheritance. 

+#include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/chrome_notification_observer.h"
 #include "extensions/browser/extensions_browser_client.h"
 
 namespace base {
 class CommandLine;
@@ skipping 84 matching lines @@
   bool IsMinBrowserVersionSupported(const std::string& min_version) override;
   ExtensionWebContentsObserver* GetExtensionWebContentsObserver(
       content::WebContents* web_contents) override;
   void ReportError(content::BrowserContext* context,
                    scoped_ptr<ExtensionError> error) override;
   void CleanUpWebView(content::BrowserContext* browser_context,
                       int embedder_process_id,
                       int view_instance_id) override;
   void AttachExtensionTaskManagerTag(content::WebContents* web_contents,
                                      ViewType view_type) override;
+  scoped_refptr<update_client::UpdateClient> CreateUpdateClient(
+      content::BrowserContext* context) override;
 
  private:
   friend struct base::DefaultLazyInstanceTraits<ChromeExtensionsBrowserClient>;
 
   // Observer for Chrome-specific notifications.
   ChromeNotificationObserver notification_observer_;
 
   // Support for ProcessManager.
   scoped_ptr<ChromeProcessManagerDelegate> process_manager_delegate_;
 
   // Client for API implementations.
   scoped_ptr<ChromeExtensionsAPIClient> api_client_;
 
   scoped_ptr<ChromeComponentExtensionResourceManager> resource_manager_;
 
   scoped_ptr<ExtensionCache> extension_cache_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsBrowserClient);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_