Plugin config format validation (and tests).

Plugin config format validation (and tests).

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e2ec1185544b547b7af6f48c43fc4375f03073d8

[pquitslund, 2015-09-23 16:44:53]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-09-23 16:48:54]

LGTM

[pquitslund, 2015-09-23 16:51:35]

Committed patchset #1 (id:1) manually as
e2ec1185544b547b7af6f48c43fc4375f03073d8 (presubmit successful).

[scheglov, 2015-09-23 17:10:49]

LGTM

https://chromiumcodereview.appspot.com/1362033002/diff/1/pkg/analyzer/test/sr...
File pkg/analyzer/test/src/plugin/plugin_config_test.dart (right):

https://chromiumcodereview.appspot.com/1362033002/diff/1/pkg/analyzer/test/sr...
pkg/analyzer/test/src/plugin/plugin_config_test.dart:48:
expect(config.plugins.toList(), hasLength(0));
Do you need this toList() invocation?
AFAIK hasLength() works with any object that has "length" getter.

[pquitslund, 2015-09-23 17:47:57]

On 2015/09/23 17:10:49, scheglov wrote:
> LGTM
> 
>
https://chromiumcodereview.appspot.com/1362033002/diff/1/pkg/analyzer/test/sr...
> File pkg/analyzer/test/src/plugin/plugin_config_test.dart (right):
> 
>
https://chromiumcodereview.appspot.com/1362033002/diff/1/pkg/analyzer/test/sr...
> pkg/analyzer/test/src/plugin/plugin_config_test.dart:48:
> expect(config.plugins.toList(), hasLength(0));
> Do you need this toList() invocation?
> AFAIK hasLength() works with any object that has "length" getter.

Right!  Fixed in
https://github.com/dart-lang/sdk/commit/7ff04709e71398e1f6f736e9fbe7e4873a172677