Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4539)

Unified Diff: chrome/renderer/net/net_error_helper.h

Issue 136203009: Support auto-reload on errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixes Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/net/net_error_helper.h
diff --git a/chrome/renderer/net/net_error_helper.h b/chrome/renderer/net/net_error_helper.h
index c61ed0f41aae8700189c92f7aae4f40b68aefffc..2800307d32900650fcde87388a51ae9e871b1720 100644
--- a/chrome/renderer/net/net_error_helper.h
+++ b/chrome/renderer/net/net_error_helper.h
@@ -11,8 +11,10 @@
#include "chrome/renderer/net/net_error_helper_core.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_frame_observer_tracker.h"
+#include "content/public/renderer/render_process_observer.h"
class GURL;
+class MockableOneShotTimer;
namespace content {
class ResourceFetcher;
@@ -30,9 +32,11 @@ struct WebURLError;
class NetErrorHelper
: public content::RenderFrameObserver,
public content::RenderFrameObserverTracker<NetErrorHelper>,
+ public content::RenderProcessObserver,
public NetErrorHelperCore::Delegate {
public:
- explicit NetErrorHelper(content::RenderFrame* render_view);
+ explicit NetErrorHelper(content::RenderFrame* render_view,
+ bool auto_reload_enabled);
Randy Smith (Not in Mondays) 2014/02/06 16:47:16 Given that there aren't any tests currently in thi
virtual ~NetErrorHelper();
// RenderFrameObserver implementation.
@@ -44,6 +48,9 @@ class NetErrorHelper
// IPC::Listener implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ // RenderProcessObserver implementation.
+ virtual void NetworkStateChanged(bool online) OVERRIDE;
+
// Examines |frame| and |error| to see if this is an error worthy of a DNS
// probe. If it is, initializes |error_strings| based on |error|,
// |is_failed_post|, and |locale| with suitable strings and returns true.
@@ -68,6 +75,8 @@ class NetErrorHelper
bool is_failed_post) OVERRIDE;
virtual void FetchErrorPage(const GURL& url) OVERRIDE;
virtual void CancelFetchErrorPage() OVERRIDE;
+ virtual void ReloadPage() OVERRIDE;
+ virtual MockableOneShotTimer* NewMockableOneShotTimer() OVERRIDE;
void OnNetErrorInfo(int status);
void OnSetAltErrorPageURL(const GURL& alternate_error_page_url);
@@ -76,6 +85,7 @@ class NetErrorHelper
const std::string& data);
scoped_ptr<content::ResourceFetcher> alt_error_page_fetcher_;
+ scoped_ptr<content::ResourceFetcher> auto_reload_page_fetcher_;
mmenke 2014/02/05 23:31:43 Not used.
Elly Fong-Jones 2014/02/10 21:42:06 Done.
NetErrorHelperCore core_;
};

Powered by Google App Engine
This is Rietveld 408576698